[Prim] add reduce_as op for paddle by zeroRains · Pull Request #63064 · PaddlePaddle/Paddle

zeroRains · 2024-03-27T15:02:46Z

PR Category

Others

PR Types

New features

Description

由于broadcast类算子的反向拆解无法适配动态shape，

在静态shape中的例子如下，

x.shape = [2,3]
y.shape = [1,3]
z = x+y 
# z.shape = [2,3]
# dz -> dy
reduce_dim = get_reduce_dim(y.shape, z.shape)
# reduce_dim = [0]
dy = sum(dz, reduce_dim, True)

但在动态shape的编译期拿不到reduce_dim，于是要添加reduce_as算子，其伪代码如下：

def reduce_as(x: Tensor, y: Tensor):
      reduce_dim = get_reduce_dim(x.shape, y.shape)
      res = sum(x, reduce_dim)
      return res

有了这个算子之后，动态shape的场景写法如下：

x.shape = [-1,3]
y.shape = [1,3]
z = x+y 
# z.shape = [-1,3]
# dz -> dy
# dz.shape = [-1,3]
dy = reduce_as(dz, y)

这个pr就是实现对reduce_as op的添加

paddle-bot · 2024-03-27T15:02:52Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle-bot · 2024-03-27T15:02:54Z

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

cyber-pioneer · 2024-04-03T08:55:52Z

+        self.python_api = paddle.sum_as
+        self.public_python_api = paddle.sum_as
+        self.op_type = "sum_as"
+        self.prim_op_type = "prim"


这个算子目前没有反向拆解，这里是不能设置的

cyber-pioneer · 2024-04-03T08:58:31Z

补充动态shape的单侧

… sum

…e/Paddle into reduce_as

… sum

…e/Paddle into reduce_as

zeroRains · 2024-04-18T06:56:29Z

由于在本地cuda 11.2环境, 本地cuda12.0环境以及CI环境都无法复现test_assign_pos_op 单测出错的场景，现将该PR的实现部分进行拆解，分成多个子PR，确认是哪个部分的改动引起了这个单测出错。这些PR并不需要Review和Merge具体PR如下：

reduce_as 前向计算： #63652

Xreki

LGTM for op-benchmark ci

sunzhongkai588

LGTM，中文也同步增加文档吧

XieYunshen

LGTM

jeff41404 · 2024-04-19T09:39:17Z

+                'float64',
+                'int16',
+                'int32',
+                'int64',


can we support other data type of complex64/128、uint8 andint8?

后续的PR再进行补充吧

This reverts commit 38182e7.

zeroRains added 3 commits March 25, 2024 13:38

add the sum_as op for paddle - part(forward)

f9ba2e5

fix the test bug

6ab282a

add the sum_as_grad but have bug in test

7b2b5d6

paddle-bot Bot added the contributor External developers label Mar 27, 2024

cyber-pioneer reviewed Mar 28, 2024

View reviewed changes

Comment thread paddle/phi/api/yaml/backward.yaml Resolved

zeroRains added 8 commits March 28, 2024 13:21

remove uncessary args but backward computing still have bug

f9a62ad

fix the python registor

b7760da

modif the test and and some case

5c8bc4c

modify the description of python api

a16be62

fix tyop

da822f5

fix the bug in test which write base on OpTest

38bd332

remove the useless function in test

9e7fa93

modift the size of the test tenor

d8c22f2

cyber-pioneer reviewed Apr 1, 2024

View reviewed changes

Comment thread test/legacy_test/test_sum_as_op.py Resolved

Comment thread test/legacy_test/test_sum_as_op.py Resolved

cyber-pioneer and others added 3 commits April 1, 2024 18:37

Update test/legacy_test/test_sum_as_op.py

6101781

Update test/legacy_test/test_sum_as_op.py

91d6d2b

fix code style

11e96ed

cyber-pioneer reviewed Apr 3, 2024

View reviewed changes

zeroRains added 2 commits April 4, 2024 06:16

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

6f4325d

… sum

add dynamic shape test and modify the doc

4636403

zeroRains closed this Apr 4, 2024

zeroRains reopened this Apr 4, 2024

zeroRains added 5 commits April 4, 2024 16:29

Update test_sum_as_op.py

89f0d8b

Update test_sum_as_op.py

e7dd69a

fix the bug in convert_np_dtype_to_dtype_

1339391

Merge branch 'sum' of https://github.com/zeroRains/Paddle into sum

9c06455

Update core.py

76ff0e4

zeroRains changed the title ~~[Prim] add sum_as op for paddle~~ [Prim] add reduce_as op for paddle Apr 9, 2024

fix the file name

c96d295

zeroRains force-pushed the sum branch from c96d295 to 77acfd3 Compare April 12, 2024 08:01

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

287d4f1

… sum

zeroRains force-pushed the sum branch from 77acfd3 to 287d4f1 Compare April 13, 2024 07:51

zeroRains and others added 6 commits April 14, 2024 12:00

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

d5d3d7b

… sum

Merge commit 'refs/pull/63064/head' of https://github.com/PaddlePaddl…

2d83a1b

…e/Paddle into reduce_as

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

c6f7e55

… sum

modify the test time

7f2168e

Merge commit 'refs/pull/63064/head' of https://github.com/PaddlePaddl…

702390a

…e/Paddle into reduce_as

fix test case

1ce4a5b

zeroRains mentioned this pull request Apr 18, 2024

[Prim] check the CI error for reduce_as op #63652

Closed

zeroRains added 3 commits April 18, 2024 10:54

fix the date

d8ac719

Merge branch 'develop' into sum

754482f

fix code style

0dfe7fa

cyber-pioneer approved these changes Apr 19, 2024

View reviewed changes

zyfncg approved these changes Apr 19, 2024

View reviewed changes

Xreki approved these changes Apr 19, 2024

View reviewed changes

sunzhongkai588 approved these changes Apr 19, 2024

View reviewed changes

XieYunshen approved these changes Apr 19, 2024

View reviewed changes

jeff41404 reviewed Apr 19, 2024

View reviewed changes

luotao1 approved these changes Apr 19, 2024

View reviewed changes

cyber-pioneer merged commit 38182e7 into PaddlePaddle:develop Apr 19, 2024

zeroRains mentioned this pull request Apr 19, 2024

[WeeklyReports] 2024.04.06~2024.04.19 周报汇总 PFCCLab/Camp#223

Closed

30 tasks done

zeroRains deleted the sum branch April 19, 2024 12:03

zeroRains mentioned this pull request Apr 19, 2024

[Prim] 为 Paddle 新增 reduce_as API 中文文档 PaddlePaddle/docs#6621

Merged

Galaxy1458 added a commit that referenced this pull request Apr 22, 2024

Revert "[Prim] add reduce_as op for paddle (#63064)"

6a12a89

This reverts commit 38182e7.

Galaxy1458 mentioned this pull request Apr 22, 2024

Revert "[Prim] add reduce_as op for paddle" #63756

Closed

zeroRains mentioned this pull request Jun 11, 2024

WAVE SUMMIT+2024上半年飞桨开源之星评选-信息征集 PaddlePaddle/community#892

Closed

Navigation Menu

Repository navigation

[Prim] add reduce_as op for paddle - #63064

[Prim] add reduce_as op for paddle#63064
cyber-pioneer merged 42 commits into
PaddlePaddle:developfrom
zeroRains:sum

zeroRains commented Mar 27, 2024 •

edited

Loading

Uh oh!

paddle-bot Bot commented Mar 27, 2024

Uh oh!

paddle-bot Bot commented Mar 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cyber-pioneer Apr 3, 2024

Uh oh!

zeroRains Apr 3, 2024

Uh oh!

cyber-pioneer commented Apr 3, 2024

Uh oh!

zeroRains commented Apr 18, 2024

Uh oh!

Xreki left a comment

Uh oh!

sunzhongkai588 left a comment

Uh oh!

XieYunshen left a comment

Uh oh!

jeff41404 Apr 19, 2024

Uh oh!

zeroRains Apr 19, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

zeroRains commented Mar 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

Uh oh!

paddle-bot Bot commented Mar 27, 2024

Uh oh!

paddle-bot Bot commented Mar 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cyber-pioneer Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

zeroRains Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

cyber-pioneer commented Apr 3, 2024

Uh oh!

zeroRains commented Apr 18, 2024

Uh oh!

Xreki left a comment

Choose a reason for hiding this comment

Uh oh!

sunzhongkai588 left a comment

Choose a reason for hiding this comment

Uh oh!

XieYunshen left a comment

Choose a reason for hiding this comment

Uh oh!

jeff41404 Apr 19, 2024

Choose a reason for hiding this comment

Uh oh!

zeroRains Apr 19, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

zeroRains commented Mar 27, 2024 •

edited

Loading